Some general improvements to the getting started guide #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
colincasey
commented
Nov 28, 2024
colincasey
commented
- Includes a shutdown handler (best practice)
- Uses a modern, async-aware test runner (Jest)
- Aligns on the change to use port 5006
- Uses a range of Node.js versions that match our currently supported versions
- Includes a shutdown handler (best practice) - Uses a modern, async-aware test runner (Jest) - Aligns on the change to use port 5006 (+3 squashed commits)
colincasey
force-pushed
the
getting_started_improvements
branch
from
5df0ad4 to
fd805c2
Compare
edmorley
approved these changes
Nov 29, 2024
Co-authored-by: Ed Morley <[email protected]>
Co-authored-by: Ed Morley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.